[PATCH] D61909: Add Clang shared library with C++ exports

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 14 11:01:56 PDT 2019


tstellar added a comment.

Thanks for working on this, I have wanted something like this for a while.

It would also be nice to have a CLANG_LINK_CLANG_DYLIB option like we have for llvm, but this can be a follow on patch, and I would be happy to help with this if needed.



================
Comment at: clang/tools/clang-shlib/CMakeLists.txt:8
+
+add_clang_library(Clang_shared
+                  SHARED
----------------
Is this capital 'C' to distinguish it from the other libclang.so ?  I would prfer to use lowercase 'c' here instead, so it fit the naming convention for the other libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61909/new/

https://reviews.llvm.org/D61909





More information about the cfe-commits mailing list