[PATCH] D61370: Add a C2x mode and allow attributes in it

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 15:00:32 PDT 2019


rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Frontend/CompilerInvocation.cpp:2593-2596
+  // Enable [[]] attributes in C++11 and C2x by default.
+  Opts.DoubleSquareBracketAttributes = Args.hasFlag(
+      OPT_fdouble_square_bracket_attributes,
+      OPT_fno_double_square_bracket_attributes, Opts.CPlusPlus11 || Opts.C2x);
----------------
(We get this wrong in a bunch of other places, but...)

The default from the language mode should be set by `setLangDefault`, and here we should override it if suitable flags are set.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61370/new/

https://reviews.llvm.org/D61370





More information about the cfe-commits mailing list