[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 14:32:43 PDT 2019


jdoerfert added a comment.

In D61765#1500351 <https://reviews.llvm.org/D61765#1500351>, @gtbercea wrote:

> - Exclude clock functions. Reverse inclusion order.


LGTM from my side. I don't have strong feelings about testing libc++ now, though it is probably a good idea to have such a testbed.
I agree this should not infer with CUDA (at least that is our intention).

P.S.
There will be a ticket to add the OpenMP variant support we need (similar to the `__device__` in CUDA) will be written by Tom Scogland and me for a first vote already in this meeting.
That is what we will then need to implement.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61765/new/

https://reviews.llvm.org/D61765





More information about the cfe-commits mailing list