[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 13 10:16:44 PDT 2019
aprantl added inline comments.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3885
+ if (ArgNo) {
+ auto *PD = dyn_cast<ParmVarDecl>(VD);
+ ParmCache[PD].reset(D);
----------------
A `dyn_cast` followed by an unconditional use seems strange. I would expect either a `cast` or an `if (PD)` check.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58035/new/
https://reviews.llvm.org/D58035
More information about the cfe-commits
mailing list