[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

Sun May 12 15:18:59 PDT 2019

hintonda added a comment.

In D61827#1499368 <https://reviews.llvm.org/D61827#1499368>, @lebedev.ri wrote:

> In D61827#1499347 <https://reviews.llvm.org/D61827#1499347>, @hintonda wrote:
>
> >
>

>> Are you saying this patch is a regression?
> 
> Not in general, no. This is most certainly an improvement for normal C++ code.

Good, then this patch can go forward.

I agree that a note that this shouldn't be run on openmp 4.  Perhaps a separate patch could check for that and not do anything when compiling an openmp file.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61827/new/

https://reviews.llvm.org/D61827