[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

Sat May 11 02:55:17 PDT 2019

JonasToth added a subscriber: shuaiwang.
JonasToth added a comment.

Hey, I do like your check!

I think it would be great to implement this analysis in `utils/` as roman suggested. Then we have bigger flexibility.
The `ExprMutAnalyzer` was requested to be moved to `clang/Analysis/` as the CSA folks wanted to reuse it at some point. That might be the case with your logic as well, as it is still related to `ExprMutAnalyzer` even though its not the same.

Another issue why the clang-tidy part for the variable const-suggestions doesn't move forward is that `ExprMutAnalyzer` itself is blocked due to @shuaiwang not having time as well. We have a view nasty cases that produce false positives and especially pointer analysis is complicated.

For that I think that @mgehre approach of producing something useful now should not be blocked on us. Especially since its unclear when we can continue our work substantially. Preparing for joining forces later would be great though! I think this is possible with having just a class/set of functions for the analysis that can be used in different parts of clang tools is sufficient for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61749/new/

https://reviews.llvm.org/D61749