[PATCH] D60974: Clang IFSO driver action.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 10 14:09:28 PDT 2019


plotfi added a comment.

In D60974#1498604 <https://reviews.llvm.org/D60974#1498604>, @compnerd wrote:

> This really needs more tests.  Please add a positive/negative test for the driver argument.  Please try to organise the tests a bit to show what it is that they are testing, emission of public functions, not of protected functions or hidden functions.  Behaviour with C++ classes.  Behaviour with templates.  I don't see any test for the vtable for classes that are public/private.


Agreed. Adding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974





More information about the cfe-commits mailing list