[PATCH] D57860: [analyzer] Validate checker option names and values

Fri May 10 13:53:53 PDT 2019

NoQ accepted this revision.
NoQ added a comment.

In D57860#1432728 <https://reviews.llvm.org/D57860#1432728>, @dcoughlin wrote:

> Setting compatibility mode to be true in the driver is not sufficient since many build systems call the frontend directly.

This doesn't seem to be the case; all build systems i'm aware of would pick up the driver flag.

We've seen really bad problems due to lack of compatibility in the past, but this time i don't foresee any, as we've already tested this for non-checker flags. Let's land this and i'll ask for a revert if it ever causes any problems.

Note that even if we revert the driver hack and keep compatibility mode on by default, we can still disable compatibility mode in LIT substitutions (i.e., in `%clang_analyze_cc1`), so that we still had checking in our tests and were sure that they test something.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57860/new/

https://reviews.llvm.org/D57860