[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added inline comments.


================
Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17
+  #include <cstdlib>
+  #include <stdlib.h>
+#endif
----------------
gtbercea wrote:
> jdoerfert wrote:
> > Why do we need the stdlib includes again?
> They are both prone to abs inclusion.
> 
> We need them here to control the order in which they are included relative to the forward_declares header.
I thought the "not defining abs" in __clang_cuda_math_forward_declares.h was the solution?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61765/new/

https://reviews.llvm.org/D61765