[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

Fri May 10 12:35:48 PDT 2019

thakis marked 2 inline comments as done.
thakis added inline comments.

================
Comment at: clang/include/clang/AST/ASTContext.h:2877
+    OCET_EncodePointerToObjCTypedef = 1 << 7,
+  };
+  void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options,
----------------
rjmccall wrote:
> I like the idea of doing this, but can you add some boilerplate? :)  I think it'd be better if this were a struct with some nice accessors, factories, transformations, and so on.
> 
> This example isn't from Clang, but something like this (without the templating, of course): https://github.com/apple/swift/blob/14a20eea03e9115e2c5cf91bccc86e6cd5334df9/include/swift/ABI/MetadataValues.h#L118
Done. It got pretty wordy (+30 lines instead of -30 before), so I x-macro'd it a bit.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61788/new/

https://reviews.llvm.org/D61788