[PATCH] D60974: Clang IFSO driver action.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 10 12:11:30 PDT 2019


plotfi marked an inline comment as done.
plotfi added a comment.

In D60974#1498240 <https://reviews.llvm.org/D60974#1498240>, @jakehehrlich wrote:

> This shouldn't emit the .tbe format at all, the .tbe format is meant to be in near 1-1 correspondence with .so files, not with .o files. It has things like DT_NEEDED, and DT_SONAME related information that don't make sense for .o files for instance.
>
> If we put things under an --experimental flags, minimize what we add in the first patch, and try and make each additional field added need based, I'm ok with whatever being added to Clang assuming it doesn't interfere with other parts of the compiler.


That sounds good. I wasn't sure if you wanted straight up tbe or not. I can basically keep what we have here and make the heading line include an "experimental" tag so that it cant be directly read by the llvm-elfabi tool without some changes. I do think it should be sufficient to have some subset of tbe as a merging format in llvm-elbabi. Will post an update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974





More information about the cfe-commits mailing list