[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

Fri May 10 00:30:05 PDT 2019

xbolva00 added inline comments.

================
Comment at: lib/Frontend/DependencyFile.cpp:279
+  if (DependencyFilter.size() &&
+      strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) == 0)
+    // Remove dependencies that are prefixed by the Filter string.
----------------
xbolva00 wrote:
> mibintc wrote:
> > I wasn't sure about using strncmp to do the prefix comparison, but i checked around in the clang code and saw strncmp used in several places so I thought it would be acceptable. 
> DependencyFilter.compare(Filename)?
They are overloads with pos and len.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61743/new/

https://reviews.llvm.org/D61743