[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 17:51:25 PDT 2019


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/test/SemaCXX/aggregate-initialization.cpp:199
   void test0() {
-    auto *y = new Y {}; // expected-error {{temporary of type 'ElementDestructor::X' has private destructor}}
+    auto *y = new Y {}; // expected-error {{calling a private destructor of class 'ElementDestructor::X}}
   }
----------------
Feel free to address this in a follow-up, but this seems like a regression.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61165/new/

https://reviews.llvm.org/D61165





More information about the cfe-commits mailing list