[PATCH] D60974: Clang IFSO driver action.

Puyan Lotfi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 08:24:33 PDT 2019


plotfi marked 2 inline comments as done.
plotfi added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3590
+            Twine("-interface-stubs-version=") +
+            Args.getLastArgValue(options::OPT_ifso_version_EQ)));
+      }
----------------
compnerd wrote:
> Please ensure that the value being passed is valid or emit a diagnostic.
Couldn't I do this in the cc1 path? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974





More information about the cfe-commits mailing list