[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Thu May 9 08:18:54 PDT 2019

sammccall added a comment.

In D50993#1496638 <https://reviews.llvm.org/D50993#1496638>, @Dmitry.Kozhevnikov wrote:

> In D50993#1496250 <https://reviews.llvm.org/D50993#1496250>, @ilya-biryukov wrote:
>
> > We should definitely land this.
> >
> > @Dmitry.Kozhevnikov, you don't have commit access, right? Should we land these two revisions for you?
>
>
> The depending review was never done for the Windows part, also I really don’t like how it’ interacting with threading disabled (that’s something I’ve realized after submitting the review) - so I’ve abandoned that, sorry. I could make an another take next week - or should we wait for D61724 <https://reviews.llvm.org/D61724>?

D61724 <https://reviews.llvm.org/D61724> has landed.

`LLVM_ENABLE_THREADS=Off` is now "officially" unsupported in clangd (rL360115 <https://reviews.llvm.org/rL360115>), so if it's not sensible to have this in llvm/Support due to LLVM_ENABLE_THREADS then we can put it in clangd instead.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50993/new/

https://reviews.llvm.org/D50993