[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

Thu May 9 08:06:46 PDT 2019

aaron.ballman reopened this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D56160#1496594 <https://reviews.llvm.org/D56160#1496594>, @aaron.ballman wrote:

> In D56160#1496391 <https://reviews.llvm.org/D56160#1496391>, @bernhardmgruber wrote:
>
> > @aaron.ballman I do not have commit privileges and I would be very thankful, if you could commit this patch for me! Thank you!
>
>
> I've commit for you in r360345, thank you for the patch!

I had to revert in r360348 as the patch does not pass the testbots: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/48063/steps/test/logs/stdio

When you correct the issues, I'm happy to reapply the patch for you. If you could also fix up the link in the release notes as part of the cleanup, that would be great (it turned out there was a typo -- I've pointed it out in the review).

================
Comment at: docs/ReleaseNotes.rst:154-155

+- New :doc:`modernize-use-trailing-type-return
+  <clang-tidy/checks/modernize-use-trailing-type-return>` check.
+
----------------
These should be `modernize-use-trailing-return-type` instead (there's a typo).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56160/new/

https://reviews.llvm.org/D56160