[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 9 05:32:24 PDT 2019
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM
================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:361
+ case BuiltinType::Float:
+ return " = 0.0F";
+ case BuiltinType::Double:
----------------
We may not have to care about this for this version of the patch, but I believe we have other checks with options to add literal suffixes in lowercase vs uppercase form. We should try to honor that the same way we're honoring using assignment vs braces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D24892/new/
https://reviews.llvm.org/D24892
More information about the cfe-commits
mailing list