[PATCH] D60934: [clang] adding explicit(bool) from c++2a
Simon Pilgrim via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 9 03:58:17 PDT 2019
RKSimon added inline comments.
================
Comment at: cfe/trunk/lib/Parse/ParseDecl.cpp:3939
+ "both or neither of isAlreadyConsumed and "
+ "RangeEnd needs to be set");
+ DS.SetRangeEnd(isAlreadyConsumed ? RangeEnd : Tok.getLocation());
----------------
@Tyker @rsmith We're seeing -Wparentheses warnings because of this - please can you take a look? The logic looks a little dodgy for a both/neither assertion as well.
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/27322/steps/build%20stage%201/logs/warnings%20%281%29
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60934/new/
https://reviews.llvm.org/D60934
More information about the cfe-commits
mailing list