[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:6369
     // very difficult. Ideally, we should handle them more gracefully.
-    if (!EIA->getCond()->EvaluateWithSubstitution(
+    if (EIA->getCond()->isValueDependent() ||
+        !EIA->getCond()->EvaluateWithSubstitution(
----------------
This is treating value-dependent `enable_if` conditions as having failed. Is that really appropriate? (When do we call this with value-depnedent `enable_if` attributes? I'd expect it to only be called after substitution)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61522/new/

https://reviews.llvm.org/D61522