[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

[Mike Rice via Phabricator via cfe-commits]

mikerice added a comment.

For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers.  So this would presumably affect only a small numbers of compilation units that only include stddef.h and none of the others.

It’s been our experience that if a user has code that compiles fine with their current compiler, and it doesn’t compile with the new compiler, they just won’t use the new compiler.  Many don’t really care that it would work fine if they added #includes where needed.  So changes like this can really improve compiler uptake.  I guess it is a trade-off between helping users easily moving their code to clang or a possible small compile time improvement.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61646/new/

https://reviews.llvm.org/D61646