[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123
Louis Dionne via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 8 07:39:53 PDT 2019
ldionne added inline comments.
================
Comment at: include/clang/Basic/AlignedExceptionObject.h:15
+
+#ifndef LLVM_CLANG_BASIC_ALIGNED_ALLOCATION_H
+#define LLVM_CLANG_BASIC_ALIGNED_ALLOCATION_H
----------------
The guards look wrong.
================
Comment at: include/clang/Basic/AlignedExceptionObject.h:31
+ case llvm::Triple::MacOSX: // Earliest supporting version is 10.14.
+ return llvm::VersionTuple(10U, 14U);
+ case llvm::Triple::IOS:
----------------
Would it make more sense to return the alignment directly here?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61667/new/
https://reviews.llvm.org/D61667
More information about the cfe-commits
mailing list