[PATCH] D61681: [clangd] A code tweak to expand a macro

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 8 07:34:54 PDT 2019


ilya-biryukov added a comment.

This actually works, but still far from landing.
Notable problems:

- this adds a dependency on `TokenBuffer`, so we need to land it first.
- this change is too big, planning to split into multiple changes: (1) collecting tokens when building the AST for clangd, (2) add helpers into `TokenBuffer`
- it currently tries to replace any "mapping", not just preprocessor expansions. E.g. will attempt to replace `#define FOO ...` with an empty string.
- needs more tests.

Will get back to it after `TokenBuffer` lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61681/new/

https://reviews.llvm.org/D61681





More information about the cfe-commits mailing list