[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 17:18:32 PDT 2019


vsk added inline comments.


================
Comment at: lib/CodeGen/CGObjCMac.cpp:6039
+    LT = llvm::GlobalValue::PrivateLinkage;
+  }
+
----------------
I see some minor variant of this logic repeated a few times. Wdyt of defining a 'getLinkageTypeForObjCMetadata(CGM, Section)' helper to consolidate it in one place?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61454/new/

https://reviews.llvm.org/D61454





More information about the cfe-commits mailing list