[PATCH] D61656: -frewrite-imports: Add support for wildcard rules in umbrella modules with

[David Blaikie via Phabricator via cfe-commits]

dblaikie marked an inline comment as done.
dblaikie added inline comments.


================
Comment at: test/Modules/preprocess-umbrella.cpp:1-2
+// FIXME: The standalone module still seems to cause clang to want to test for
+// the existence of a 'foo' directory:
+// RUN: mkdir %t
----------------
rsmith wrote:
> FWIW, I think that probably happens when parsing the `umbrella "foo"` directive.
Thanks for the pointer - yeah, I'd come across that too. Both the ModuleMap and the Module ( https://clang.llvm.org/doxygen/classclang_1_1Module.html#acb7c8570da610974e567675303baa77b ) depend on a non-null DirectoryEntry to record the modules umbrella-ness.

Any ideas on how I might go about removing that limitation?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61656/new/

https://reviews.llvm.org/D61656