[PATCH] D61497: [clangd] Introduce a structured hover response

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:73
+  llvm::Optional<std::vector<Param>> Parameters;
+  llvm::Optional<std::vector<Param>> TemplateParameters;
+
----------------
kadircet wrote:
> ilya-biryukov wrote:
> > What does `Type` mean for non-type and template template parameters?
> > Could you add a comment?
> added comment for template template parameters.
> 
> For non-type template params, isn't it clear that this will hold the type of that param? e.g `template <C<int>... X>` -> `C<int>...`
Ah, sure, sorry, I meant the type parameters :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61497/new/

https://reviews.llvm.org/D61497