[PATCH] D61506: [OpenCL] Switch to C++17

Tue May 7 02:57:04 PDT 2019

Anastasia marked an inline comment as done.
Anastasia added a comment.

In D61506#1490555 <https://reviews.llvm.org/D61506#1490555>, @rsmith wrote:

> Per the OpenCL C++ 1.0 specification, section 2:
>
> > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 N 3690 language specification (a.k.a. C++14 specification).
>
> I think it would be reasonable to permit changing the base C++ standard in OpenCL C++ mode, but we'd need a good reason to deviate from the behavior specified in the OpenCL C++ specification by default.

I am in discussion with Khronos about changing the directions for this spec and I believe some announcements will appear hopefully soon.

================
Comment at: include/clang/Frontend/LangStandards.def:162
              OpenCL, "OpenCL C++ 1.0",
-             LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | Digraphs | OpenCL)
+             LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | CPlusPlus17 | Digraphs | OpenCL)

----------------
keryell wrote:
> kpet wrote:
> > Suggest you add `HexFloat` as well. It is part of c++17 and all OpenCL versions.
> Why only C++17?
> I would love to have `CPlusPlus2a` here too...
I would love to have `C++2a` too but it's currently an experimental feature only and I can't see any timeline about when this will become production quality. As we are planning to release C++ for OpenCL in production quality during this year I am afraid it won't be possible to include `C++2a` at this point .

Perhaps this is something we can do in the future.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61506/new/

https://reviews.llvm.org/D61506