[PATCH] D61497: [clangd] Introduce a structured hover response

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 02:41:00 PDT 2019


kadircet marked 2 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:73
+  llvm::Optional<std::vector<Param>> Parameters;
+  llvm::Optional<std::vector<Param>> TemplateParameters;
+
----------------
ilya-biryukov wrote:
> What does `Type` mean for non-type and template template parameters?
> Could you add a comment?
added comment for template template parameters.

For non-type template params, isn't it clear that this will hold the type of that param? e.g `template <C<int>... X>` -> `C<int>...`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61497/new/

https://reviews.llvm.org/D61497





More information about the cfe-commits mailing list