[PATCH] D61601: [clangd] Represent Hover result using FormattedString

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 02:14:22 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/Protocol.cpp:707
+  else
+    return false;
+  return true;
----------------
kadircet wrote:
> kadircet wrote:
> > Maybe also vlog/elog the unknown kind? So that we can easily catch new additions to spec.
> I was referring to the `else` case down below :D
Thanks for catching that!
My mistake, I made the change but did not save the file.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61601/new/

https://reviews.llvm.org/D61601





More information about the cfe-commits mailing list