[PATCH] D61601: [clangd] Represent Hover result using FormattedString

Tue May 7 01:27:54 PDT 2019

ilya-biryukov added a comment.

In D61601#1492979 <https://reviews.llvm.org/D61601#1492979>, @kadircet wrote:

> I think it makes more sense to expose semantical information in HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, and let this be serialized by the users of ClangdServer (as in D61497 <https://reviews.llvm.org/D61497>). This is what I'll perform with that patch anyway, since it aims to provide consumers of ClangdServer with sementical information. So it is up to you whether to change the layering or keep it as it is in this patch.

Having structured information instead of `FormattedString` looks good, this change mostly aims to add markdown support for resulting hover when the LSP clients have support for it.
I'm happy to restructure the `HoverInfo` to your liking if the current one seems problematic for any reason.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61601/new/

https://reviews.llvm.org/D61601