[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

Tom Rix via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 6 15:42:14 PDT 2019


trixirt added a comment.

All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard.
The much smaller llvm and bugprone subclasses are only concerned with the style of the fix.

My understanding of the directory layout guidance in the docs is that different styles get different directories.

  Next, you need to decide which module the check belongs to. Modules
  are located in subdirectories of `clang-tidy/
  <https://github.com/llvm/llvm-project/tree/master/clang-tools-extra/clang-tidy/>`_
  and contain checks targeting a certain aspect of code quality (performance,
  readability, etc.), certain coding style or standard (Google, LLVM, CERT, etc.)
  or a widely used API (e.g. MPI). Their names are same as user-facing check
  groups names described :ref:`above <checks-groups-table>`.

So keep as-is ?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61508/new/

https://reviews.llvm.org/D61508





More information about the cfe-commits mailing list