[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 6 15:09:24 PDT 2019


leonardchan marked 2 inline comments as done.
leonardchan added inline comments.


================
Comment at: lib/Sema/SemaType.cpp:4913-4916
+        ExpectNoDerefChunk = false;
+      }
+
+      ExpectNoDerefChunk = state.didParseNoDeref();
----------------
dblaikie wrote:
> Pointed out in PR41774 there's a dead store to ExpectNoDerefChunk here.
> 
> Should line 4913 be removed (& then the two if conditions can be collapsed together)?
Yup, fixed in r360089


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49511/new/

https://reviews.llvm.org/D49511





More information about the cfe-commits mailing list