[PATCH] D61399: [OpenMP][Clang] Support for target math functions

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: lib/Headers/__clang_cuda_cmath.h:54
 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); }
+#ifndef _OPENMP
 __DEVICE__ int fpclassify(float __x) {
----------------
gtbercea wrote:
> ABataev wrote:
> > Why we have this guard here? It does not work for OpenMP? Why?
> Because all the FP_XXX macros are defined in cmath and for OpenMP we can't include it yet because we don't support variant yet.
The better to add TODO or FIXME to fix this once `variant` construct in supported.


================
Comment at: lib/Headers/__clang_cuda_device_functions.h:49
+#if defined(__cplusplus)
 __DEVICE__ void __brkpt(int __a) { __brkpt(); }
+#endif
----------------
gtbercea wrote:
> ABataev wrote:
> > Can we do anything with this in С mode? I mean, to allow it in C.
> We can if we rename the function.
Take a look here, probably it will solve the problem:
https://clang.llvm.org/docs/AttributeReference.html#overloadable


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61399/new/

https://reviews.llvm.org/D61399