[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 6 07:19:20 PDT 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clangd/ClangdServer.cpp:264
                           Callback<std::vector<TextEdit>> CB) {
-  auto Action = [Pos](Path File, std::string NewName,
+  auto Action = [Pos](std::string File, std::string NewName,
                       Callback<std::vector<TextEdit>> CB,
----------------
Why change Path to std::string ?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61596/new/

https://reviews.llvm.org/D61596





More information about the cfe-commits mailing list