[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Nice! Looking at the numbers, the improvements look worthwhile.

The stopwords don't seem to be in the patch anymore, but they do seem like a good idea. Specifically, we might want to remove all keywords - the intuition is that they don't provide much value, because users **have** to put them.



================
Comment at: clangd/unittests/CodeCompleteTests.cpp:25
 #include "clang/Tooling/CompilationDatabase.h"
+#include "llvm/Support/AtomicOrdering.h"
 #include "llvm/Support/Error.h"
----------------
This included was probably added accidentally. Remove?


================
Comment at: clangd/unittests/CodeCompleteTests.cpp:29
 #include "llvm/Testing/Support/Error.h"
+#include "gmock/gmock-generated-matchers.h"
 #include "gmock/gmock.h"
----------------
This include is redundant, maybe remove it? (added by clangd for sure)


================
Comment at: clangd/unittests/SourceCodeTests.cpp:25
 using llvm::HasValue;
+using testing::UnorderedElementsAreArray;
 
----------------
NIT: use `::testing` to be consistent with the rest of the code in clangd?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61537/new/

https://reviews.llvm.org/D61537