[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime
Gheorghe-Teodor Bercea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 5 12:11:32 PDT 2019
gtbercea marked an inline comment as done.
gtbercea added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
+ if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) {
+ HasEmittedDeclareTargetRegion = true;
----------------
ABataev wrote:
> ABataev wrote:
> > No need for the braces
> What if `declare target` is used only for variabes but not for the functions?
Even more reason to error in that case since it may contain clauses like link or to which need for requires directives to be used consistently.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60568/new/
https://reviews.llvm.org/D60568
More information about the cfe-commits
mailing list