[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

Fri May 3 11:21:19 PDT 2019

hintonda added a comment.

In D61269#1490176 <https://reviews.llvm.org/D61269#1490176>, @thakis wrote:

> I happened to see this go by. Is there an explanation of the overall goal somewhere? In general, requiring -- for long flags sounds like a great change to me, but there are a few exceptions: For example. lld-link should keep accepting long flags with a single dash for link.exe compatibility.

The 5th and final patch, D61294 <https://reviews.llvm.org/D61294>, "[CommandLine] Add long option flag for cl::ParseCommandLineOptions . Part 5 of 5", adds a flag that requires long options use the `--`.  It's an opt-in strategy, so only tools that want the GNU `getopt_long` behavior would want to set it.  Otherwise, everything works the way it does currently, with the exception of help printing `--` for long options.

As noted in D61294 <https://reviews.llvm.org/D61294>, these changes were motivated by this discussion:  http://lists.llvm.org/pipermail/llvm-dev/2019-April/131786.html

Of course, this doesn't change tblgen generated options which are a different animal.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61269/new/

https://reviews.llvm.org/D61269