[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:135-137
+    const UnaryExprOrTypeTraitExpr *LeftUnaryExpr =
+        cast<UnaryExprOrTypeTraitExpr>(Left);
+    const UnaryExprOrTypeTraitExpr *RightUnaryExpr =
----------------
`const auto *` since you already spell the type in the initializer.


================
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:832
 
-
 void RedundantExpressionCheck::checkBitwiseExpr(
----------------
Not that I oppose the cleanup, but there are a bunch of these kinds of changes that are orthogonal to the patch. Feel free to commit these cleanups as an NFC commit and then rebase on top of it if you'd like, but they shouldn't be in this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55125/new/

https://reviews.llvm.org/D55125