[PATCH] D48292: use modern type trait implementations when available

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 3 10:09:21 PDT 2019


ldionne added a comment.

In D48292#1490060 <https://reviews.llvm.org/D48292#1490060>, @thakis wrote:

> This test is broken with Xcode 9:
>
>   [...]
>
>
> Does this just need an `// XFAIL: apple-clang-9` or is this unexpected?


This seems to have been fixed in LLVM Clang trunk since the 8 release, and AppleClang 9 just doesn't have that fix. So I think it's reasonable to XFAIL it.

Clang 8: https://wandbox.org/permlink/nung9OHLrvObZGjq
Clang 9 (trunk): https://wandbox.org/permlink/y8e3UUx6CDf8x7im


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48292/new/

https://reviews.llvm.org/D48292





More information about the cfe-commits mailing list