[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/misc/HeaderGuardCheck.cpp:21
+                                                 StringRef OldGuard) {
+  if (OldGuard.size()) {
+    return OldGuard;
----------------
Please use early return.


================
Comment at: docs/clang-tidy/checks/misc-header-guard.rst:14
+   A comma-separated list of filename extensions of header files (the filename
+   extensions should not include "." prefix). Default is "h,hh,hpp,hxx".
+   For header files without an extension, use an empty string (if there are no
----------------
Please use single back-tick instead of quotes for option values. Same below.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61508/new/

https://reviews.llvm.org/D61508