[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 3 06:36:38 PDT 2019


ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/FormattedString.h:27
+  /// Append plain text to the end of the string.
+  void appendText(std::string Text);
+  /// Append a block of C++ code. This translates to a ``` block in markdown.
----------------
sammccall wrote:
> I guess this will get an optional parameter to control the style (bold, italic etc)?
Either that or a separate function to add bold/italic, etc.
I think we should keep it simple in the first revision.

This really tries to provide a vocabulary type to carry a string with formatted blocks around, not support full markdown from the start.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58547/new/

https://reviews.llvm.org/D58547





More information about the cfe-commits mailing list