[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 3 04:52:24 PDT 2019
alexfh added a comment.
Apart from NOLINT handling there's more logic in `ClangTidyDiagnosticConsumer::HandleDiagnostic`, which isn't properly transferred to `ClangTidyContext::diag` in this patch. The logic that is transferred seems to change the behavior w.r.t. notes that can "unmute" ignored warnings (see https://reviews.llvm.org/D59135#1456108). I suspect that we're missing proper test coverage here. Another issue is that compiler diagnostics don't pass ClangTidyContext::diag in the non-plugin use case. Do all the existing tests pass with your patch?
A better way to implement diagnostic filtering in the plugin would be to make ClangTidyDiagnosticConsumer able to forward diagnostics to the external diagnostics engine. It will still need some sort of a buffering though to handle diagnostics and notes attached to them together.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61487/new/
https://reviews.llvm.org/D61487
More information about the cfe-commits
mailing list