[PATCH] D61480: Added an AST matcher for declarations that are in the `std` namespace

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 3 01:15:23 PDT 2019


aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

You should also update Registry.cpp to add this to clang-query and you should also regenerate the documentation by running clang\docs\tools\dump_ast_matchers.py.



================
Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2079
+}
+
 TEST(EqualsBoundNodeMatcher, QualType) {
----------------
Can you also add a negative test case for:
```
namespace foo {
namespace std {
  void bar(); // isInStdNamespace() is false here, right?
}
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61480/new/

https://reviews.llvm.org/D61480





More information about the cfe-commits mailing list