[PATCH] D61357: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: lib/Sema/SemaOverload.cpp:3518-3519
           << false << From->getType() << From->getSourceRange() << ToType;
   } else
     return false;
+
----------------
Can we avoid calling `CompleteCandidates` on this path?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61357/new/

https://reviews.llvm.org/D61357