[PATCH] D61442: [clangd] Fix header-guard check for include insertion, and don't index header guards.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 2 07:38:50 PDT 2019


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

Both of these attempt to check whether a header guard exists while parsing the
file. However the file is only marked as guarded once clang finishes processing
it. We defer the checks and work until SymbolCollector::finish().

This is ugly and ad-hoc, deferring *all* work might be cleaner.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D61442

Files:
  clangd/index/Symbol.cpp
  clangd/index/Symbol.h
  clangd/index/SymbolCollector.cpp
  clangd/index/SymbolCollector.h
  clangd/unittests/SymbolCollectorTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61442.197780.patch
Type: text/x-patch
Size: 9172 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190502/29ab0790/attachment.bin>


More information about the cfe-commits mailing list