[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 1 10:10:27 PDT 2019
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22
+ // Verify the existence and validity of the AST node that roots this rule.
+ auto &NodesMap = Result.Nodes.getMap();
+ auto Root = NodesMap.find(tooling::RewriteRule::RootId);
----------------
Please don't use auto when return type is not spelled at same statement or iterator. Same for other places.
================
Comment at: clang-tools-extra/unittests/clang-tidy/TransformerTidyTest.cpp:10
+#include "../clang-tidy/utils/TransformerTidy.h"
+
+#include "ClangTidyTest.h"
----------------
Unnecessary empty line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61386/new/
https://reviews.llvm.org/D61386
More information about the cfe-commits
mailing list