[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 1 06:14:29 PDT 2019


aaron.ballman added a comment.

In D61239#1485994 <https://reviews.llvm.org/D61239#1485994>, @JornVernee wrote:

> - holding of on adding helper method until hearing back.


My rationale for wanting a helper method is because we already have two places were incompleteness is important but has special cases. It's easier to maintain that with something that's a named function to explain what the predicate is actually doing. My concern is that we add another `isIncompleteType()` and not think about this issue.

Do we need this in `validateFieldParentType()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61239/new/

https://reviews.llvm.org/D61239





More information about the cfe-commits mailing list