[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 1 04:43:39 PDT 2019


MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.


================
Comment at: lib/Format/FormatTokenLexer.cpp:249
+  Identifier->ColumnWidth += Question->ColumnWidth;
+  Identifier->Type = Identifier->Type;
+  Tokens.erase(Tokens.end() - 1);
----------------
RKSimon wrote:
> @MyDeveloperDay Should this be
> ```
> Identifier->Type = Question->Type;
> ```
> Reported in https://www.viva64.com/en/b/0629/
I think most likely  I want to keep it as an identifier so we are treating arg? as arg

I feel like this line is probably not needed, there is a review for this.. {D61281}


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58404/new/

https://reviews.llvm.org/D58404





More information about the cfe-commits mailing list