[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 1 01:32:25 PDT 2019


Anastasia added a comment.

I would suggest an IR test, especially since what you want to achieve is addrspacecast in IR output. We use AST dump only if there is no other good way to test something. In fact we already have a test with similar logic that tests various OpenCL address spaces: test/CodeGenOpenCLCXX/addrspace-of-this.cl. I think it should be reasonable enough to extend it.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61319/new/

https://reviews.llvm.org/D61319





More information about the cfe-commits mailing list