[PATCH] D61147: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 30 16:04:26 PDT 2019


ahatanak added a comment.

In D61147#1479932 <https://reviews.llvm.org/D61147#1479932>, @rjmccall wrote:

> I would also recommend that you go fix the warning to never fire on virtual C++ methods.


I tried building clang/llvm with  -Wunused-parameter turned on and there are lots of places where parameters are unused other than virtual functions, in particular template functions and non-template functions that are called by other template functions. So disabling the warning on C++ virtual functions is probably not enough in order to make this warning more useful.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61147/new/

https://reviews.llvm.org/D61147





More information about the cfe-commits mailing list