[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

Mon Apr 29 19:09:04 PDT 2019

jdoerfert added inline comments.

================
Comment at: lib/Driver/ToolChains/Clang.cpp:1159
+      getToolChain().getTriple().isNVPTX())
+    getToolChain().AddMathDeviceFunctions(Args, CmdArgs);
+
----------------
Here is another "NVPTX" specialization that I don't think we need. At least with more targets we need to relax this condition.

================
Comment at: lib/Headers/__clang_openmp_math.h:13
+
+#ifdef __NVPTX__
+#pragma omp declare target
----------------
Why is this NVPTX specific (again)?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60907/new/

https://reviews.llvm.org/D60907